Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(release): fix tag variable #273

Merged
merged 1 commit into from
Aug 10, 2023
Merged

ci(release): fix tag variable #273

merged 1 commit into from
Aug 10, 2023

Conversation

JonZeolla
Copy link
Member

@JonZeolla JonZeolla commented Aug 10, 2023

Contributor Comments

We accidentally used steps. which works if you are in the same job as the output creation; we need to move it to needs.

Pull Request Checklist

Thank you for submitting a contribution to easy_infra!

In order to streamline the review of your contribution we ask that you review and comply with the below requirements:

  • Rebase your branch against the latest commit of the target branch
  • If you are adding a dependency, please explain how it was chosen
  • If manual testing is needed in order to validate the changes, provide a testing plan and the expected results
  • If there is an issue associated with your Pull Request, link the issue to the PR.

@JonZeolla JonZeolla enabled auto-merge (squash) August 10, 2023 16:23
Copy link
Contributor

@ChiefHolland ChiefHolland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@JonZeolla JonZeolla merged commit a652ead into main Aug 10, 2023
19 checks passed
@JonZeolla JonZeolla deleted the fix-release branch August 10, 2023 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants